Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The container is always set #1128

Merged
merged 1 commit into from
Jan 20, 2020
Merged

The container is always set #1128

merged 1 commit into from
Jan 20, 2020

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Jan 20, 2020

Follow up of #1090

@rosier @greg0ire
Consider container as always set
2834c4b 
This implies removing an unnecessary check, and documenting the property
holding the container as non-nullable.
greg0ire
greg0ire approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the phpdoc of the property

@ostrolucky ostrolucky merged commit a3828da into doctrine:master Jan 20, 2020
@alcaeus alcaeus added this to the 2.1.0 milestone Jan 21, 2020
@rosier rosier deleted the patch-1 branch January 27, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees

@ostrolucky ostrolucky

Labels
Improvement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rosier @greg0ire @dmaicher @alcaeus @ostrolucky